Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(backend): tenanted quotes #3171

Draft
wants to merge 1 commit into
base: 2893/multi-tenancy-v1
Choose a base branch
from
Draft

feat(backend): tenanted quotes #3171

wants to merge 1 commit into from
+497 −76

Conversation

sanducb
Copy link
Contributor

@sanducb sanducb commented Dec 10, 2024 •
edited
Loading

Changes proposed in this pull request

  • The purpose of this PR is to make quotes tenated as per multi-tenant design
  • Still WIP, as this first iteration only deals with "plugging in" tenantId all across the backend logic and tests. A dummy tenant/operator was created and its id was used everywhere as a hardcoded value in tests. The following step would be to replace the hardcoded values with proper tenant creation via tenant service.
  • TODOs will be dealt with as well

Context

fixes #3118

Checklist

  • Related issues linked using fixes #number
  • Tests added/updated
  • Make sure that all checks pass
  • Bruno collection updated (if necessary)
  • Documentation issue created with user-docs label (if necessary)
  • OpenAPI specs updated (if necessary)

@sanducb sanducb linked an issue Dec 10, 2024 that may be closed by this pull request
[Multi-Tenant] Tenanted Quotes #3118
Open
4 tasks
@github-actions github-actions bot added type: tests Testing related pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. type: source Changes business logic pkg: auth Changes in the GNAP auth package. pkg: mock-ase pkg: mock-account-service-lib labels Dec 10, 2024
@netlify Netlify
Copy link

netlify bot commented Dec 10, 2024 •
edited
Loading

✅ Deploy Preview for brilliant-pasca-3e80ec ready!

Name Link
🔨 Latest commit 8ef2027
🔍 Latest deploy log https://app.netlify.com/sites/brilliant-pasca-3e80ec/deploys/6758541a24fdd400087e2d57
😎 Deploy Preview https://deploy-preview-3171--brilliant-pasca-3e80ec.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sanducb sanducb changed the base branch from main to 2893/multi-tenancy-v1 December 10, 2024 14:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
pkg: auth Changes in the GNAP auth package. pkg: backend Changes in the backend package. pkg: frontend Changes in the frontend package. pkg: mock-account-service-lib pkg: mock-ase type: source Changes business logic type: tests Testing related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Multi-Tenant] Tenanted Quotes
1 participant
@sanducb